Workstealing take 3 #58500
Draft
Workstealing take 3 #58500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seelengrab
reviewed
May 22, 2025
|
|
||
| mutable struct Node{T} | ||
| const value::Union{T, Nothing} | ||
| @atomic next::Union{Node{T}, Nothing} |
Contributor
There was a problem hiding this comment.
You can keep this type stable by having next point to itself in case there is no next object.
Contributor
There was a problem hiding this comment.
That'd just replace the small union get_next(node) === nothing with a get_next(node) === node check everywhere though. Not sure it'd help performance, and it'd likely cause some annoying footguns.
Member
There was a problem hiding this comment.
Intent could at least be made clearer with a helper function hasnext(node) = get_next(node) != node.
vchuravy
reviewed
May 23, 2025
| # Weak Memory Models | ||
| # ======= | ||
|
|
||
| module CLL |
Member
There was a problem hiding this comment.
Did you update this with my bugfixes?
Member
Author
There was a problem hiding this comment.
I think I did. the x86 specific stuff was part of them but I also didn't test CLL too much (just that it built)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just forward ports the workstealing PR to be on top of #56475 though that PR is a lot more mergeable than this one.